fix: Properly handle relational tables metrics#1788
Merged
Conversation
erezrokah
requested review from
a team,
bbernays and
marianogappa
and removed request for
bbernays
marianogappa
approved these changes
Jul 9, 2024
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
🤖 I have created a release *beep* *boop* --- ## [4.49.2](v4.49.1...v4.49.2) (2024-07-09) ### Bug Fixes * Properly handle relational tables metrics ([#1788](#1788)) ([ee16898](ee16898)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to table OTEL metrics support.
For relational tables
OtelStartTimeandOtelEndTimeare called multiple times (per parent resource), so we were reporting the start and end time incorrectly (adding up all the times).This PR fixes it so only the first start time is reported, and the end time gets updated to the latest value.
Another possible fix to the end time is to set it to whenever the parent table finishes syncing, but I don't think that's very useful.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)