Skip to content
This repository was archived by the owner on Sep 15, 2020. It is now read-only.

implement verbosity#2

Merged
resmo merged 4 commits intomasterfrom
feature/verbosity
May 30, 2020
Merged

implement verbosity#2
resmo merged 4 commits intomasterfrom
feature/verbosity

Conversation

@resmo
Copy link
Contributor

@resmo resmo commented May 27, 2020

No description provided.

@resmo resmo requested review from davidhalter and gaudenz May 27, 2020 14:44
@resmo resmo added the enhancement New feature or request label May 27, 2020
@gaudenz
Copy link
Contributor

gaudenz commented May 27, 2020

This feature looks nice. No comments on the code itself. I have just one suggestion. I would call the command line parameter --debug and the environment variable CLOUDSCALE_DEBUG instead. The output this produces looks more like debugging output. As a user I would expect a --verbose option to output more information about the objects (eg. more detailed server list), not more information about the API requests done. Also with the Python logging formatting this looks more like debugging output.

Something a bit different not really specific to this PR: Is there a way to make certain CLI flags "global" so you don't have to define them for every command? Currently there is a lot of code duplication for all the flags that are the same for each command.

Copy link
Contributor

@gaudenz gaudenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above.

@resmo
Copy link
Contributor Author

resmo commented May 27, 2020

This feature looks nice. No comments on the code itself. I have just one suggestion. I would call the command line parameter --debug and the environment variable CLOUDSCALE_DEBUG instead. The output this produces looks more like debugging output. As a user I would expect a --verbose option to output more information about the objects (eg. more detailed server list), not more information about the API requests done. Also with the Python logging formatting this looks more like debugging output.

--debug would be indeed a appropriate option name.

Something a bit different not really specific to this PR: Is there a way to make certain CLI flags "global" so you don't have to define them for every command? Currently there is a lot of code duplication for all the flags that are the same for each command.

Currently the only reason against "globaly" options is the cloudscale-cli version case, which takes no optioins at all. But at the end to have a non-functional options for cloudscale-cli version would not a big issue IMHO.

@gaudenz
Copy link
Contributor

gaudenz commented May 28, 2020

I would live with the non functional options on the version command (or make that an option itself --version) and make the common options global. But I leave this up to you and this is certainly nothing for this PR.

@resmo
Copy link
Contributor Author

resmo commented May 29, 2020

needs rebase and I would like to merge #4 first and working on top

@resmo resmo changed the title implement verbosity WIP: implement verbosity May 29, 2020
@resmo resmo force-pushed the feature/verbosity branch from ff5e3ea to f5c409b Compare May 30, 2020 14:37
@resmo resmo changed the title WIP: implement verbosity implement verbosity May 30, 2020
@resmo resmo merged commit b6ce97e into master May 30, 2020
@resmo resmo deleted the feature/verbosity branch May 30, 2020 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants