This repository was archived by the owner on Sep 15, 2020. It is now read-only.
Conversation
implements output option
This was referenced May 29, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I move the common options such as
--api-tokento the cli group, as a consequence the CLI syntax slightly change fromcloudscale-cli server ---api-token <token> create ...to
cloudscale-cli --api-token <token> server createwhich actually makes a lot more "sense" because, these options are not specific to the server resource.
Further the
versionoptions is removed and replaced by click internal version option but had to change it to--versionarg (I tried it withversionbut click is not happy).A refactoring was done in
commands,_init__where I moved the functions to a newCloudscaleCommandwrapper class. This allowed to easily implement the--outputoption and I did it along (but I have some ideas to make it more generic and add probably add yaml and toml output.)With the refactoring in place, the command group files become very slick, only a resource name for the attribute in the cloudscale lib
cloudscale.<resource_name>is necessary and some headers for the table output.Test coverage is 99% (seems the github actions don't run, cloud you check, I don't have access).