chore: Fixes dry run for build tools#123
Merged
Merged
Conversation
pan-kot
force-pushed
the
fix-build-tools-dry-run
branch
from
2e8f5f3 to
4393ece
Compare
amanabiy
reviewed
Jul 7, 2026
Comment on lines
+48
to
+51
| if (!buildToolsRef) { | ||
| return dependencies; | ||
| } | ||
| if (dependencies['@cloudscape-design/build-tools']) { |
Member
There was a problem hiding this comment.
Should we combine this conditional statement?
if (buildToolsRef && dependencies['@cloudscape-design/build-tools']) {
...
}
return dependencies;
pan-kot
force-pushed
the
fix-build-tools-dry-run
branch
from
4393ece to
a9ec618
Compare
amanabiy
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build tools dependency is installed directly from GitHub, thus the existing dry-run mechanism did not apply. As result, the dry-run job of build tools used the mainline version instead of the branch version.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.