Skip to content

chore: Widen peerDependencies to accept react-router-dom 7 - #72

Merged
ernst-dev merged 1 commit into
mainfrom
dependabot-remediate/security-remediation-20260807
Aug 7, 2026
Merged

chore: Widen peerDependencies to accept react-router-dom 7#72
ernst-dev merged 1 commit into
mainfrom
dependabot-remediate/security-remediation-20260807

Conversation

@ernst-dev

Copy link
Copy Markdown
Member

Summary

Upgrades react-router-dom from ^6.30.4 to ^7.18.2 (dev dependency) to resolve all 3 open Dependabot security alerts.

NPMPM availability

Not applicable — all upgraded packages are dev-only dependencies (dev: true in lockfile). No non-dev dependency versions increased.

Alerts resolved

Package Major line Vulnerable range Resolved version Severity Advisory
react-router 6.x >= 6.0.0, < 7.18.0 7.18.2 medium GHSA-wrjc-x8rr-h8h6 / CVE-2026-53669
react-router 6.x >= 6.4.0, < 7.18.0 7.18.2 medium GHSA-337j-9hxr-rhxg / CVE-2026-53666
react-router-dom 6.x >= 6.30.2, <= 6.30.4 7.18.2 medium GHSA-jjmj-jmhj-qwj2 / CVE-2026-53668

Remediation details

  • Rung used: 3 (targeted npm install react-router-dom@^7.18.2 --save-dev) with HW4 lockfile splice — no patch available within 6.x; all 3 alerts require the 6→7 major version upgrade.
  • Override added: No
  • Lockfile splice (HW4): Applied to avoid npm's full tree reconciliation which removed 70+ unrelated non-dev packages (stylelint and deps). The spliced diff contains only the security-relevant entries.
  • Peer dep note: react-router-dom 7 has peerDependencies: {react: '>=18'} but this repo pins react@16.14.0 as a devDependency. Installed with --legacy-peer-deps. Since react-router-dom is only a dev dependency used for dev pages, this mismatch is acceptable.
  • Classification:
    • ALERT-DRIVEN: react-router 6.30.4 → 7.18.2, react-router-dom 6.30.4 → 7.18.2
    • COLLATERAL: cookie@1.1.1 added (new react-router dep), set-cookie-parser@2.7.2 added (new react-router dep), @remix-run/router@1.23.3 removed (no longer used in v7)

Unresolved alerts

None — merging this PR is expected to CLEAR ALL 3 open Dependabot alerts for this repo.

Notes

  • react-router-dom is a devDependency only, used for dev pages / testing. The 6→7 migration is a breaking change for application code but low-risk for this repo's dev tooling.
  • The HW2 first-party strip was applied (no @cloudscape-design/* entries in lockfile).
  • Net diff: 48 insertions, 26 deletions across package.json + package-lock.json.

@ernst-dev
ernst-dev requested a review from a team as a code owner August 7, 2026 12:29
@ernst-dev
ernst-dev requested review from avinashbot and removed request for a team August 7, 2026 12:29
@ernst-dev
ernst-dev force-pushed the dependabot-remediate/security-remediation-20260807 branch from 161126c to 9d5713c Compare August 7, 2026 13:43
ernst-dev added a commit to cloudscape-design/board-components that referenced this pull request Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'.
Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72),
npm ci needs legacy-peer-deps to resolve the optional peer without failing.

This file can be removed once build-tools#72 is merged.
ernst-dev added a commit to cloudscape-design/chart-components that referenced this pull request Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'.
Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72),
npm ci needs legacy-peer-deps to resolve the optional peer without failing.

This file can be removed once build-tools#72 is merged.
ernst-dev added a commit to cloudscape-design/chat-components that referenced this pull request Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'.
Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72),
npm ci needs legacy-peer-deps to resolve the optional peer without failing.

This file can be removed once build-tools#72 is merged.
ernst-dev added a commit to cloudscape-design/code-view that referenced this pull request Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'.
Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72),
npm ci needs legacy-peer-deps to resolve the optional peer without failing.

This file can be removed once build-tools#72 is merged.
ernst-dev added a commit to cloudscape-design/component-toolkit that referenced this pull request Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'.
Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72),
npm ci needs legacy-peer-deps to resolve the optional peer without failing.

This file can be removed once build-tools#72 is merged.
@ernst-dev
ernst-dev force-pushed the dependabot-remediate/security-remediation-20260807 branch from 8ff05a8 to 008aa49 Compare August 7, 2026 13:52
Adds ^7.0.0 to the peerOptional react-router-dom range so consuming
repos can upgrade to react-router-dom 7 without peer dep conflicts.

The 3 Dependabot alerts on this repo (GHSA-wrjc-x8rr-h8h6,
GHSA-337j-9hxr-rhxg, GHSA-jjmj-jmhj-qwj2) remain UNFIXABLE here:
react-router-dom 7 requires react>=18, but this package must retain
react@16 support. No patched version exists within the 6.x line.
@ernst-dev
ernst-dev force-pushed the dependabot-remediate/security-remediation-20260807 branch from 008aa49 to 23bd560 Compare August 7, 2026 13:53
@ernst-dev ernst-dev changed the title chore: Remediate 3 Dependabot security alerts (react-router-dom 6→7) chore: Widen peerDependencies to accept react-router-dom 7 Aug 7, 2026
@ernst-dev
ernst-dev enabled auto-merge August 7, 2026 14:07
@ernst-dev
ernst-dev added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit d108f6e Aug 7, 2026
42 checks passed
@ernst-dev
ernst-dev deleted the dependabot-remediate/security-remediation-20260807 branch August 7, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants