chore: Replaced hardcoded css values with design tokens - #257
Conversation
| padding-inline: cs.$space-static-m; | ||
| background-color: cs.$color-background-container-content; | ||
| border-radius: 8px; | ||
| border-radius: cs.$border-radius-popover; |
There was a problem hiding this comment.
I also considered introducing a new design token for it, but using the existing popover token seems appropriate here
There was a problem hiding this comment.
I think a specific design token is a better option. Although the popover border radius happens to have the same default value as this element, they are semantically distinct. Would everyone who customizes the popover border radius expect the chart empty state indicator to change as well? I'd say not necessarily.
Alternatively, maybe border-radius-card-embedded is acceptable, since this is similar to a card embedded in a chart.
There was a problem hiding this comment.
$border-radius-card-embedded sounds like a good option, addressed. I wouldn’t introduce a new token for this element. Although the elements are semantically different, border radiuses should remain consistent across similar components in the design system
Description
Replaced hardcoded border radiuses with Cloudscape design tokens, because they cause a regression in the 1T. No visual changes for VR.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.