Skip to content

feat: expose renderStep prop of Steps - #4466

Merged
amanabiy merged 1 commit into
mainfrom
dev-v3-amanabiy-thinking-pattern
Apr 26, 2026
Merged

feat: expose renderStep prop of Steps#4466
amanabiy merged 1 commit into
mainfrom
dev-v3-amanabiy-thinking-pattern

Conversation

@amanabiy

@amanabiy amanabiy commented Apr 24, 2026

Copy link
Copy Markdown
Member

Description

This PR makes the renderStep available to be used with our new thinking pattern. Se related links to learn more.

Related links, issue #, if available: izviAVvSF39f

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amanabiy
amanabiy requested a review from a team as a code owner April 24, 2026 06:15
@amanabiy
amanabiy requested review from NathanZlion and removed request for a team April 24, 2026 06:15
@amanabiy amanabiy changed the title feat(steps, icon): expose renderStep prop and add dot icon feat: expose renderStep prop and add dot icon Apr 24, 2026
@amanabiy
amanabiy marked this pull request as draft April 24, 2026 07:23
@amanabiy
amanabiy marked this pull request as ready for review April 24, 2026 08:30
@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (eb9e00b) to head (2ce98dd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4466   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         933      933           
  Lines       29486    29486           
  Branches    10698    10698           
=======================================
  Hits        28720    28720           
  Misses        718      718           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

NathanZlion
NathanZlion previously approved these changes Apr 24, 2026

@NathanZlion NathanZlion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, one slight question though. Is the size of the icon intentional? Just making sure.

Image

@timogasda

Copy link
Copy Markdown
Member

Shouldn't these be two separate PRs/commits for the sake of separation of concerns? @amanabiy

@amanabiy
amanabiy force-pushed the dev-v3-amanabiy-thinking-pattern branch from 386c36f to 2ce98dd Compare April 24, 2026 15:11
@amanabiy amanabiy changed the title feat: expose renderStep prop and add dot icon feat: expose renderStep prop of Steps Apr 24, 2026
@amanabiy
amanabiy requested a review from NathanZlion April 24, 2026 15:12
@amanabiy

Copy link
Copy Markdown
Member Author

@NathanZlion I confirmed with the designer that this is the expected icon size, it's a tiny icon meant to sit within its 16px × 16px container. I've also separated the icon addition into a separate PR: #4468

@amanabiy
amanabiy added this pull request to the merge queue Apr 24, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 24, 2026
@amanabiy
amanabiy added this pull request to the merge queue Apr 26, 2026
Merged via the queue into main with commit f5628d2 Apr 26, 2026
52 checks passed
@amanabiy
amanabiy deleted the dev-v3-amanabiy-thinking-pattern branch April 26, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants