feat: Add support to AppLayoutToolbar for collapsed side navigation - #4688
Merged
Conversation
georgylobko
force-pushed
the
dev-v3-jkuelz-app-layout-navigation
branch
from
July 9, 2026 11:26
527a33d to
e8f300c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4688 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 951 951
Lines 30744 30766 +22
Branches 11281 11302 +21
=======================================
+ Hits 30007 30029 +22
Misses 690 690
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
georgylobko
force-pushed
the
dev-v3-jkuelz-app-layout-navigation
branch
from
July 15, 2026 11:29
03f8399 to
d3c5abc
Compare
georgylobko
force-pushed
the
dev-v3-jkuelz-app-layout-navigation
branch
from
July 20, 2026 15:51
41afe36 to
e145c44
Compare
pan-kot
reviewed
Jul 21, 2026
pan-kot
reviewed
Jul 21, 2026
pan-kot
reviewed
Jul 21, 2026
pan-kot
reviewed
Jul 21, 2026
|
|
||
| export default function CollapsedWithAppLayoutPage() { | ||
| const appLayoutRef = useRef<AppLayoutProps.Ref>(null); | ||
| const [navOpen, setNavOpen] = useState(false); |
Member
There was a problem hiding this comment.
nit: For page settings we usually use url state with AppContext. This allows to share links with specific presets and simplifies setup for screenshot tests.
pan-kot
reviewed
Jul 21, 2026
pan-kot
reviewed
Jul 21, 2026
pan-kot
reviewed
Jul 21, 2026
pan-kot
approved these changes
Jul 22, 2026
georgylobko
enabled auto-merge
July 22, 2026 11:30
georgylobko
disabled auto-merge
July 22, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AppLayoutandAppLayoutToolbarnow supportSideNavigationin its collapsed state. The navigation slot correctly reflects the collapsed width and adjusts layout calculations accordingly.Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.