feat: TextContent blockquote styling - #4760
Draft
ernst-dev wants to merge 1 commit into
Draft
Conversation
Adds a `blockquote` rule to the TextContent component styles using Cloudscape design tokens: - Left border accent using `$border-divider-section-width` and `$color-border-divider-default` - Body text colour via `$color-text-body-default` - Block spacing with `$space-scaled-xs` (margin) and `$space-xxs` (padding-block) - Inline start padding via `$space-m` for comfortable indentation - Italic font style to visually distinguish quoted content Also updates the Typography permutations dev page with single-line and multi-line blockquote examples, and adds unit tests. Closes #4172
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements blockquote styling for the TextContent component, resolving #4172.
Adds a
blockquoterule tosrc/text-content/styles.scssusing Cloudscape typography and colour tokens:$border-divider-section-width$color-border-divider-default$color-text-body-default$space-scaled-xs$space-xxs$space-mThis keeps the blockquote visually consistent with the Cloudscape design language while clearly distinguishing quoted content from surrounding body text.
Related links, issue #, if available: Closes #4172
How has this been tested?
src/text-content/__tests__/text-content-blockquote.test.tsx(all pass)pages/text-content/permutations.page.tsxwith single-line and multi-line blockquote examplesReview checklist
Correctness
blockquotewas previously unstyled inside TextContent; adding a rule is additive.Security
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.