Skip to content

feat: gap side nav items when icons are present - #4831

Merged
mxschll merged 2 commits into
mainfrom
dev-v3-schomax-sidenav
Jul 24, 2026
Merged

feat: gap side nav items when icons are present#4831
mxschll merged 2 commits into
mainfrom
dev-v3-schomax-sidenav

Conversation

@mxschll

@mxschll mxschll commented Jul 24, 2026

Copy link
Copy Markdown
Member

Description

Changes spacing between nav items in side nav when icons are present.

Related links, issue #, if available: n/a

How has this been tested?

Locally + Pipeline.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.61%. Comparing base (90c8d77) to head (a84223c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4831   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files         952      952           
  Lines       30816    30820    +4     
  Branches    11318    11318           
=======================================
+ Hits        30081    30085    +4     
- Misses        688      728   +40     
+ Partials       47        7   -40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll
mxschll marked this pull request as ready for review July 24, 2026 13:31
@mxschll
mxschll requested a review from a team as a code owner July 24, 2026 13:31
@mxschll
mxschll requested review from NathanZlion, amanabiy and jkuelz and removed request for a team July 24, 2026 13:31
@mxschll
mxschll added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit 51998d0 Jul 24, 2026
59 checks passed
@mxschll
mxschll deleted the dev-v3-schomax-sidenav branch July 24, 2026 17:12
},
spaceSideNavigationItemGap: {
description: 'The vertical gap between side navigation items.',
spaceSideNavigationItemDefaultGap: {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this would be a breaking change because the token was already public and themeable. The impact is likely minimal, but just FYI.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, did a quick lookup and haven't found usages besides our own. Since it's been quietly introduced recently I think it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants