feat: gap side nav items when icons are present - #4831
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4831 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 952 952
Lines 30816 30820 +4
Branches 11318 11318
=======================================
+ Hits 30081 30085 +4
- Misses 688 728 +40
+ Partials 47 7 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mxschll
marked this pull request as ready for review
July 24, 2026 13:31
mxschll
requested review from
NathanZlion,
amanabiy and
jkuelz
and removed request for
a team
July 24, 2026 13:31
amanabiy
approved these changes
Jul 24, 2026
jkuelz
reviewed
Jul 24, 2026
| }, | ||
| spaceSideNavigationItemGap: { | ||
| description: 'The vertical gap between side navigation items.', | ||
| spaceSideNavigationItemDefaultGap: { |
Member
There was a problem hiding this comment.
Technically, this would be a breaking change because the token was already public and themeable. The impact is likely minimal, but just FYI.
Member
Author
There was a problem hiding this comment.
Yes, did a quick lookup and haven't found usages besides our own. Since it's been quietly introduced recently I think it's ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes spacing between nav items in side nav when icons are present.
Related links, issue #, if available: n/a
How has this been tested?
Locally + Pipeline.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.