fix: alert action buttons on top navigation surface - #4872
Closed
mxschll wants to merge 1 commit into
Closed
Conversation
mxschll
changed the title
mxschll
commented
Aug 6, 2026
| builder.addContext(createFlashbarWarningContext((await import('./contexts/flashbar-warning.js')).tokens)); | ||
| builder.addContext(createAlertContext((await import('./contexts/alert.js')).tokens)); | ||
| builder.addContext(createHeaderAlertContext((await import('./contexts/header-alert.js')).tokens)); | ||
| builder.addContext(createTopNavigationAlertContext((await import('./contexts/header-alert.js')).tokens)); |
Member
Author
There was a problem hiding this comment.
Mirrors what createHeaderAlertContext is doing for header contexts.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4872 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 957 957
Lines 31140 31140
Branches 11463 11463
=======================================
Hits 30404 30404
Misses 689 689
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
YueyingLu
approved these changes
Aug 6, 2026
YueyingLu
requested changes
Aug 6, 2026
YueyingLu
left a comment
YueyingLu
left a comment
Member
There was a problem hiding this comment.
Revert approval because of bundle size increase found in offline discussion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alerts inside top navigation rendered light-mode button colors on the dark surface, making action buttons look disabled.
Before
After
Includes a test page rendering flashbar and alert permutations on the top navigation surface.
Part of a stacked change; base for #4866.