feat: check archive tooling before download#10
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
- Adds a preflight step to
install.shso required archive-extraction and SHA-256 verification tools are validated after manifest resolution but before downloading the release archive, avoiding unnecessary transfers when tooling is missing. - Extends the Bats test suite to assert the manifest is fetched while the release archive is not requested when
taror checksum tooling is unavailable, and updates docs/changelog to describe the behavior.
Changes:
- Add
check_archive_toolspreflight ininstall.shand invoke it beforedownload_archive. - Add Bats coverage for “missing tar” and “missing checksum tool” pre-download failure behavior.
- Document the new preflight behavior in
README.mdandCHANGELOG.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
install.sh |
Adds preflight validation of archive + checksum tooling before archive download. |
tests/install.bats |
Adds regression tests ensuring missing tools fail before archive download. |
README.md |
Documents the post-manifest, pre-download tooling checks. |
CHANGELOG.md |
Notes the new preflight tool-check behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
check_archive_tools also validated SHA-256 tooling, so rename it to check_required_tools; document the conditional tar/gzip vs unzip requirement in the README.
cloudsmith-iduffy
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archive
tarandgzipfor tarballs, orunzipfor ZIP filesthat are only needed for a new archive
before any archive request
Type of change
Validation
sh -n install.shshellcheck --shell=sh --severity=style install.shbats tests/— 45 tests passedtarcoverage confirms that the manifest is requested but therelease archive is not
the release archive is not
git diff --checkCompatibility
No changes to supported targets, command-line options, environment variables,
installation paths, or the four-line output contract. Installations missing a
required archive or checksum tool now fail before transferring the release
archive instead of failing afterward.
The installer does not reject BusyBox
tarby name. Its documented tar appletsupports the
t,x,v,z,f, andCoperations used here, while theexisting archive validation and extraction steps remain authoritative.
Checklist
CHANGELOG.mdwhere appropriate.