refactor(no-ticket): extract shared templates.render() from webserver - #329
Merged
Conversation
Move the placeholder-based template renderer from cloudsmith_cli/cli/webserver.py into the templates package so other callers (upcoming Maven credential helper) can reuse it. webserver keeps thin wrappers; behavior is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
cloudsmith-iduffy
changed the title
cloudsmith-iduffy
marked this pull request as ready for review
July 30, 2026 21:22
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the CLI’s placeholder-based template rendering logic out of cloudsmith_cli/cli/webserver.py into the cloudsmith_cli.templates package so it can be reused by non-webserver callers while preserving existing rendering semantics.
Changes:
- Added shared
templates.template_path()andtemplates.render()helpers to centralize placeholder substitution. - Updated
cli/webserver.pytemplate helpers to delegate to the sharedtemplatespackage (removing duplicated renderer logic).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cloudsmith_cli/templates/init.py | Introduces shared template path resolution and placeholder-based rendering utilities. |
| cloudsmith_cli/cli/webserver.py | Replaces in-module template rendering/path logic with thin wrappers around cloudsmith_cli.templates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
BartoszBlizniak
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prep refactor split out of #314 (stacked: this PR merges first).
Moves the placeholder-based template renderer out of
cloudsmith_cli/cli/webserver.pyinto thetemplatespackage as a sharedtemplates.render()(+template_path()), so non-HTML callers — the Maven credential helper in #314 renders itssettings.xmlwith it — can reuse it.webserver.pykeeps thin wrappers delegating to the new functions; rendering behavior is unchanged (<!-- KEY_PLACEHOLDER -->substitution, empty string for falsy values).No functional changes intended; existing webserver/login tests cover the moved code paths.
Type of Change
🤖 Generated with Claude Code