This repository was archived by the owner on Mar 16, 2022. It is now read-only.
Metadata support for JavaScript#367
Merged
jroper merged 2 commits intocloudstateio:masterfrom Jul 8, 2020
Merged
Conversation
jroper
force-pushed
the
js-metadata-support
branch
from
9db6965 to
15a7c19
Compare
viktorklang
reviewed
Jun 24, 2020
| handleCommand(command) { | ||
| const ctx = this.createContext(command.id); | ||
| let metadata = new Metadata([]); | ||
| if (command.metadata && command.metadata.entries) { |
Contributor
There was a problem hiding this comment.
Perhaps superfluous, but would it not make sense to check that the length of the entries are > 0?
Member
Author
There was a problem hiding this comment.
It will never be an empty array - it will be undefined if the array is empty, since when a sequence in protobuf is empty, nothing gets encoded, and then when protobufjs decodes that, the result is that it never sets the entries property.
viktorklang
reviewed
Jun 24, 2020
| } | ||
|
|
||
| repeated SideEffect side_effects = 4; | ||
| repeated SideEffect side_effects = 5; |
jroper
force-pushed
the
js-metadata-support
branch
from
15a7c19 to
9552207
Compare
jroper
force-pushed
the
js-metadata-support
branch
from
9552207 to
9fa75de
Compare
Co-authored-by: Peter Vlugter <pvlugter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #366 being merged first.