This repository was archived by the owner on Oct 1, 2024. It is now read-only.
including the actual exception, as part of the 'onShutdown' notification payload #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfaza
force-pushed
the
feature/DTPORTAL-2738-implementing_Airbrake_for_CRBN
branch
from
47ad49b to
7e7e860
Compare
sfgeorge
reviewed
Apr 3, 2017
| return; | ||
| } | ||
| $exc = new Errors\Fatal($error['message'], $error['file'], $error['line']); | ||
| $exc = new Errors\Fatal($error['message'], $error['file'], $error['line'], $trace = array(), $error['type']); |
There was a problem hiding this comment.
Thanks for doing this, man.
Could you also update onError() such that each of the Base objects that it creates is given the $code as the 5th argument to the constructor?
…part of the notification payload
gfaza
force-pushed
the
feature/DTPORTAL-2738-implementing_Airbrake_for_CRBN
branch
from
7e7e860 to
a3b93de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attn @sfgeorge,
abandoned original idea of passing the exception into the notification. as it turns out, the notification is meant to mimic an Exception, so made more sense to pass the error code instead. this way we'd simply use the
getCodemethod that the Exception interface expects.