Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Fix backtrace unit test #2

Merged
ajayanty merged 3 commits into from
Apr 6, 2017
Merged

Fix backtrace unit test #2

ajayanty merged 3 commits into from
Apr 6, 2017

Conversation

@sfgeorge
Copy link

@sfgeorge sfgeorge commented Apr 4, 2017 •
edited
Loading 

.....F.....

Time: 73 ms, Memory: 5.25MB

There was 1 failure:

1) Airbrake\Tests\NotifyTest::testPostsBacktrace
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     'file' => '/Users/sgeorge/Code/ifbyphone...se.php'
-    'line' => 764
+    'line' => 742
     'function' => 'Airbrake\Tests\NotifyTest->setUp'
 )

phpbrake/tests/NotifierTest.php:48

FAILURES!
Tests: 11, Assertions: 17, Failures: 1.

@sfgeorge sfgeorge force-pushed the feature/fix-backtrace-unit-test branch from ee40de2 to e697ec8 Compare April 4, 2017 13:17
@sfgeorge
Ensure test suite runs on PHP 7
147a11c 
Prevent this:

```
$ phpunit
PHPUnit 6.0.9 by Sebastian Bergmann and contributors.

Time: 86 ms, Memory: 10.00MB

No tests executed!

The command "phpunit" exited with 0.
```
@sfgeorge sfgeorge force-pushed the feature/fix-backtrace-unit-test branch from 2b5a825 to e42f10b Compare April 4, 2017 13:33
@sfgeorge
Copy link
Author

sfgeorge commented Apr 4, 2017

@gfaza Can you review this for me?

@sfgeorge sfgeorge force-pushed the feature/fix-backtrace-unit-test branch from e42f10b to 68b6882 Compare April 4, 2017 14:17
gfaza
gfaza reviewed Apr 4, 2017
View reviewed changes
tests/NotifierTest.php
$this->assertEquals($error['message'], 'hello');
}

public function testPostsBacktrace()
Copy link

@gfaza gfaza Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dig it.

gfaza
gfaza approved these changes Apr 4, 2017
View reviewed changes
Copy link

@gfaza gfaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sfgeorge
Copy link
Author

sfgeorge commented Apr 4, 2017

Thanks, mate!

@ajayanty Can you merge this?

@sfgeorge sfgeorge mentioned this pull request Apr 4, 2017
Merged
@ajayanty ajayanty merged commit 6358cff into cloudvox:support/v0.0.7.x Apr 6, 2017
kamerynn added a commit to kamerynn/phpbrake that referenced this pull request Jun 26, 2019
@kamerynn
Empty commit cloudvox#2
94908c3
mattcar added a commit that referenced this pull request Jun 26, 2019
@mattcar
Merge pull request #8 from kamerynn/empty-commit-2
61a35d4 
Empty commit #2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gfaza gfaza gfaza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfgeorge @gfaza @ajayanty