chore: modify stream copy#4
Merged
Merged
Conversation
* chore: remove stream reader close protection * chore: genericTransformWithCallbacks stream copy See merge request: !219
N3kox
approved these changes
Dec 16, 2024
|
go-test-coverage report: |
hi-pender
added a commit
that referenced
this pull request
Dec 3, 2025
# This is the 1st commit message: feat(ci): enable golangci-lint # This is the commit message #2: feat(ci): ignore fieldalignment and some funlen # This is the commit message #3: feat(ci): add comments for exported # This is the commit message #4: feat(ci): ignore some var-naming # This is the commit message #5: feat(ci): add comments fix(ci): add comments fix(ci): fix formats
shentongmartin
added a commit
that referenced
this pull request
Apr 15, 2026
…leware - Rename BeforeToolCall type to Checker; pass *adk.ToolContext instead of bare toolName (Thread #1) - Rename NewMiddleware to New to match codebase convention (Thread #4) - Improve error messages with tool name, call ID, and args for LLM consumption (Thread #5) - Replace schema.Pipe with StreamReaderFromArray for stream deny path (Thread #6) - Add 4 E2E ask→resume tests: approved, denied, re-interrupt non-target, resume with updated input (Thread #7) Change-Id: If43ac495fa3a5fc1d71a27db9614cb996d4547b5
shentongmartin
added a commit
that referenced
this pull request
Apr 15, 2026
…leware - Rename BeforeToolCall type to Checker; pass *adk.ToolContext instead of bare toolName (Thread #1) - Rename NewMiddleware to New to match codebase convention (Thread #4) - Improve error messages with tool name, call ID, and args for LLM consumption (Thread #5) - Replace schema.Pipe with StreamReaderFromArray for stream deny path (Thread #6) - Add 4 E2E ask→resume tests: approved, denied, re-interrupt non-target, resume with updated input (Thread #7) Change-Id: If43ac495fa3a5fc1d71a27db9614cb996d4547b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: remove stream reader close protection
chore: genericTransformWithCallbacks stream copy