Skip to content

refactor: SetRunInfo#5

Merged
shentongmartin merged 1 commit into
mainfrom
refactor/cbs
Dec 17, 2024
Merged

refactor: SetRunInfo#5
shentongmartin merged 1 commit into
mainfrom
refactor/cbs

Conversation

@shentongmartin
Copy link
Copy Markdown
Contributor

Change-Id: Ic602e6d3af3dec90d4ff26bc194e764a38617c7a

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 17, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

go-test-coverage report:

No coverage report available ```

Change-Id: Ic602e6d3af3dec90d4ff26bc194e764a38617c7a
@shentongmartin shentongmartin changed the title refactor: SetRunInfo && AppendCallbackHandlers refactor: SetRunInfo Dec 17, 2024
@shentongmartin shentongmartin merged commit 87f38b5 into main Dec 17, 2024
@shentongmartin shentongmartin deleted the refactor/cbs branch December 17, 2024 11:17
hi-pender added a commit that referenced this pull request Dec 3, 2025
# This is the 1st commit message:

feat(ci): enable golangci-lint

# This is the commit message #2:

feat(ci): ignore fieldalignment and some funlen

# This is the commit message #3:

feat(ci): add comments for exported

# This is the commit message #4:

feat(ci): ignore some var-naming

# This is the commit message #5:

feat(ci): add comments

fix(ci): add comments

fix(ci): fix formats
shentongmartin added a commit that referenced this pull request Apr 15, 2026
…leware

- Rename BeforeToolCall type to Checker; pass *adk.ToolContext instead of bare toolName (Thread #1)
- Rename NewMiddleware to New to match codebase convention (Thread #4)
- Improve error messages with tool name, call ID, and args for LLM consumption (Thread #5)
- Replace schema.Pipe with StreamReaderFromArray for stream deny path (Thread #6)
- Add 4 E2E ask→resume tests: approved, denied, re-interrupt non-target, resume with updated input (Thread #7)

Change-Id: If43ac495fa3a5fc1d71a27db9614cb996d4547b5
shentongmartin added a commit that referenced this pull request Apr 15, 2026
…leware

- Rename BeforeToolCall type to Checker; pass *adk.ToolContext instead of bare toolName (Thread #1)
- Rename NewMiddleware to New to match codebase convention (Thread #4)
- Improve error messages with tool name, call ID, and args for LLM consumption (Thread #5)
- Replace schema.Pipe with StreamReaderFromArray for stream deny path (Thread #6)
- Add 4 E2E ask→resume tests: approved, denied, re-interrupt non-target, resume with updated input (Thread #7)

Change-Id: If43ac495fa3a5fc1d71a27db9614cb996d4547b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants