Initial support for TLS#247
Conversation
|
Wow! This is a really great pr to implement an important feature! Thanks very much for your contribution! |
|
Furthermore, I think we should still preserve the |
I doubt this though. I personally do not remember other open source library crates doing the same thing. Plus, I have just looked through a few closed PRs, and seems like |
|
Edit: Nvm, updated my nightly toolchain and this problem is gone. Should there be a minimum toolchain version somewhere though? |
In fact, we have tried to remove the Cargo.lock before, but we encountered some problems, such as I have updated the dependency in my dev environment, but other people didn't, so after they pull the code, they will encounter compile failure, and may lead to extra communication cost. |
We are supposed to have a MSRV of 1.75 in the future. But for now, we recommend to use the latest nightly. |
I still think there are better ways to get around this, but if that's really troubling for you, I am fine with tracking |
PureWhiteWu
left a comment
There was a problem hiding this comment.
LGTM,Thanks for your contribution!
@bobozhengsir @Millione PTAL
|
Thanks again for your contribution! |
An initial attempt to add TLS support for gRPC.
Motivation
#6
Solution
Two new features flags are added
"rustls"and"native-tls"so that user can choose the preferred TLS implementation in the community. A new client/server example that uses"rustls"is added to showcase the usage.Additionally,
Cargo.lockis removed from the tracked files in git.