Fix error in the initial TLS server impl

[minghuaw]

This PR fixes an oversight introduced in the earlier PR #247 which would cause the server to break out of the listening loop should there be a TLS handshake error.

Motivation

The TLS handshake was performed with the following line in #247

let stream = tls_acceptor.accept(tcp).await?;

The ? operator would return the error and end up breaking the loop.

Solution

The TLS handshake error will be logged instead of returning. The code above is replaced with

let stream = match tls_acceptor.accept(tcp).await {
    Ok(stream) => stream,
    Err(err) => {
        tracing::debug!("[VOLO] TLS handshake error: {:?}", err);
        continue;
    },
};

[minghuaw]

Is there an agreed approach on how integration tests should be set up for volo? I was thinking of adding integration tests for this kind of things but was not sure whether you guys have any preference on how it should be set up.

[PureWhiteWu]

Thanks very much for this bugfix!

Is there an agreed approach on how integration tests should be set up for volo? I was thinking of adding integration tests for this kind of things but was not sure whether you guys have any preference on how it should be set up.

In fact, we have three long-running stability testing services in our production environment internally, and after any changes have been made, the services will update to the latest code.

I feel it is very important and valuable to include some integration tests directly in this repository. I would be grateful if you could help.

I've filed an issue #251 for this, maybe we can discuss more there.

[PureWhiteWu]

PTAL @Millione