Skip to content

SPIR spec template is dead code: no prompt, consult type, or porch check references it #1279

Description

@waleedkadous

Problem (reported from a production SPIR workspace, 2026-07-28; flagged by the owner)

codev-skeleton/protocols/spir/templates/spec.md exists but nothing in the pipeline delivers or enforces it:

  1. prompts/specify.md never references the template — it describes required content in prose only.
  2. Porch's spec-approval gate checks only that the spec file exists, not its structure.
  3. consult-types/spec-review.md has no template/structure check.

Net effect: builders never see the template unless they go looking. In the reporting workspace, the builder pattern-matched the previous spec's free-form structure, 3-way review passed it, and both of that repo's SPIR specs are off-template — discovered only when the human asked why.

Suggested fixes (any/all, from the report)

  • Reference the template explicitly in prompts/specify.md ('structure per templates/spec.md' — or better, per the deliver-don't-fetch convention, inline the required heading skeleton into the prompt).
  • Add a structure line to the spec-review consult type so reviewers check it.
  • Optionally: a porch check for required headings at spec-approval.

Audit scope

The same disease presumably applies to plan/review templates in SPIR and to ASPIR/PIR skeletons — audit all template references across protocols before fixing one.

Sequencing note

Land AFTER PR #1278 (Spec 1252) merges — that PR makes codev-skeleton/ the single owner of these files and adds the ownership map; this issue's fix should register the templates' wiring in that map rather than creating new unowned references. Conceptually this is the same class 1252 attacked: an authored artifact with no owning consumer is dead code that silently rots.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/protocolsArea: Protocol definitions — distinct from area/porch (orchestration)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions