Skip to content

Stream Deck: phaseArtifactVerb doesn't map the verify-approval gate (Automatic press falls back to terminal) #1431

Description

@amrmelsayed

Problem (surfaced by the pir-1428 builder while mirroring gateIconFor, 2026-08-12)

phaseArtifactVerb (apps/streamdeck/src/actions.ts:229-239) maps gates spec-approval, plan-approval, dev-approval, pr - but not verify-approval, which the VS Code sidebar's gate vocabulary knows (gateIconFor in apps/vscode/src/views/builder-row.ts maps it to the verified codicon). A builder blocked at verify-approval returns undefined, so the Builder Action Automatic press opens a terminal instead of the review artifact, and the phase-aware dial mode resolves through the same resolver.

Fix

Add verify-approval to the gate branch, returning view-diff (same as dev-approval/pr - the human is reviewing completed work). One line plus a test alongside the existing gate cases.

Protocol

BUGFIX (isolated one-line mapping gap with existing test patterns; no hardware gate needed - the resolver is fully unit-tested). Sequence after #1428 merges to avoid actions.ts churn.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/streamdeckStream Deck plugin — apps/streamdeck, Elgato channel (profiles, Maker Console, packaging)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions