Fix 1252 baseline reproduction test: pin the frozen sample set - #1290
Merged
Conversation
The reproduction test measured live codev/projects/ history against the committed n=160 baseline, so any later project's first consultation broke it (160 -> 163 via project 1286's worktree). A frozen baseline needs a frozen sample: add MeasureOptions.includeProjects and pin the test to the 18 projects the committed baseline was computed over. M12b forward tracking is unaffected (it measures live state by design).
waleedkadous
added a commit
that referenced
this pull request
Jul 29, 2026
waleedkadous
added a commit
that referenced
this pull request
Jul 30, 2026
waleedkadous
added a commit
that referenced
this pull request
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
prompt-behavior-metrics.test.tsreproduces the committed Spec-1252 behavioural baseline (b1_totalVerdicts = 160) by measuring livecodev/projects/history. Any project that runs consultations after the baseline was cut adds verdicts and breaks the test — discovered by the aspir-1286 builder, whose first review iteration moved the count 160 → 163 in its worktree. Every in-flight and future builder PR would hit the same CI failure, inviting per-PR "bump the number" commits that would quietly destroy the baseline's meaning.Fix
A frozen baseline needs a frozen sample:
MeasureOptions.includeProjects— an optional allowlist applied before the existingexcludeProjects, so a caller can pin the measured set.sampleProjectsequals that list.The M12b forward tracking (next-10-projects comparison vs the baseline) is unaffected — it measures live state by design; only the point-in-time reproduction is pinned.
Testing
All 9 tests in the file pass. The pinned set makes new-project perturbation impossible by construction; a failure of this test now means the measurement code's semantics changed, which is the only thing it was ever meant to guard.
🤖 Generated with Claude Code