Skip to content

Update title normalization test #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alistairjcbrown merged 1 commit into from
Aug 2, 2026
Merged

Update title normalization test #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/known-removable-phrases.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ const knownRemovablePhrases = [
"Only 4 Days to Go:",
"Only 3 Days to Go:",
"Only 2 Days to Go:",
"Only 1 Days to Go:",
"Only 1 Day to Go:",
"Open Captioned Previews",
"Open City Documentary Festival Combined Programme:",
"Open City Documentary Festival:",
Expand Down
24 changes: 24 additions & 0 deletions common/tests/test-titles.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85282,5 +85282,29 @@
{
"input": "The Last Guest of the Holloway Motel + Directors Q&A",
"output": "last guest of the holloway motel"
},
{
"input": "London's Last Wilderness at the Close Up Cinema Shoreditch.",
"output": "londons last wilderness"
},
{
"input": "Only 1 Day to Go: Tangerine (2015)",
"output": "tangerine (2015)"
},
{
"input": "Get to Know Your Camera Like a Pro - One Day Intensive Workshop: Photography Workshop with Hannah Davis",
"output": "get to know your camera like a pro"
},
{
"input": "Immersed In Shadows: Premiere Screening + Q&A",
"output": "immersed in shadows"
},
{
"input": "Portraits With Confidence - One Day Intensive Workshop for Beginners: Photography Workshop with Hannah Davis",
"output": "portraits with confidence"
},
{
"input": "Somewhere To Stay",
"output": "somewhere to stay"
}
]
4 changes: 4 additions & 0 deletions common/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,9 @@ const isPrivateHire = (title = "") =>
basicNormalize(title).includes("conferencing 6 hour") ||
basicNormalize(title).includes("do not book");

const isOnline = (title = "") =>
basicNormalize(title).includes("online workshop");

// Backoff schedule (ms) for an overloaded model (502/503). Observed 503 "high
// demand" failures cluster into bad windows of up to ~12 min rather than being
// independent, so a higher attempt count alone doesn't help — total elapsed
Expand Down Expand Up @@ -912,6 +915,7 @@ module.exports = {
getId,
generateShowingId,
isPrivateHire,
isOnline,
runLlmFunction,
getValidClassification,
parseTitleAndClassification,
Expand Down
2 changes: 2 additions & 0 deletions scripts/transform/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const {
basicNormalize,
removeMatchingHints,
isPrivateHire,
isOnline,
} = require("../../common/utils");
const { isSportShowing } = require("../../common/is-sport-showing");
const { getCinema } = require("../../cinemas");
Expand Down Expand Up @@ -123,6 +124,7 @@ async function transform(
for (const movie of previousReleaseData) {
// Don't bring unbookable events back in
if (isPrivateHire(movie.title)) continue;
if (isOnline(movie.title)) continue;

// Don't bring sports showings back in
if (isSportShowing(movie)) continue;
Expand Down