Skip to content

Conversation

@pfs
Copy link
Contributor

@pfs pfs commented Mar 17, 2025

This PR adds the remaining partials to the Si wafer map for HGCAL.
@cseez : with respect to the original file I just changed WType to Typecode in the original file as this how it's currently used in CMSSW.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pfs for branch main.

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @iarspider, @kpedro88, @makortel, @mdhildreth, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2025

cms-bot internal usage

@pfs
Copy link
Contributor Author

pfs commented Mar 17, 2025

assign hgcal-dpg

@cmsbuild
Copy link
Contributor

New categories assigned: hgcal-dpg

@cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

Pull request #2 was updated.

@pfs
Copy link
Contributor Author

pfs commented Apr 10, 2025

We have found out a typo in some of the rows and updated the PR

@pfs
Copy link
Contributor Author

pfs commented May 8, 2025

can this be merged please?

@smuzaffar
Copy link
Contributor

@pfs , is there any CMSSW PR to go along with this?

@smuzaffar
Copy link
Contributor

test parameters:

  • addpkg = Geometry/HGCalMapping, RecoLocalCalo/HGCalRecAlgos

@smuzaffar
Copy link
Contributor

@pfs , I see that this data file is mentioned in Geometry/HGCalMapping, RecoLocalCalo/HGCalRecAlgos cmssw packages but looks like there is no unit test to use it. Is there any test/relval which make use of changes here?

@pfs
Copy link
Contributor Author

pfs commented May 22, 2025

Can this be merged ? This maps the last Si wafers that we start having to commission in the lab. It would be great to have this by default in CMSSW

@pfs
Copy link
Contributor Author

pfs commented May 22, 2025

@pfs , I see that this data file is mentioned in Geometry/HGCalMapping, RecoLocalCalo/HGCalRecAlgos cmssw packages but looks like there is no unit test to use it. Is there any test/relval which make use of changes here?

I thought I had answered - apologies. There are not yet test/relval samples. We are preparing the pull requests needed to enable one workflow making use of these.

@cmsbuild
Copy link
Contributor

Pull request #2 was updated.

@pfs
Copy link
Contributor Author

pfs commented Jun 2, 2025

please test

@pfs
Copy link
Contributor Author

pfs commented Jun 2, 2025

likewise for #3 can this PR be merged? I need it to start defining a workflow in CMSSW so that it starts to be used regularly (this PR defines the readout of all Si modules which are expected in geometry). We have tested the usage of this (and the file of #3) during the 18th Hackathon (the results of slides 14-34 of the "final scrum" relied implicitly on these files). Thanks!

@pfs
Copy link
Contributor Author

pfs commented Jun 2, 2025

+1

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89bd7c/47450/summary.html
COMMIT: c2821e1
CMSSW: CMSSW_15_1_X_2025-07-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/Geometry-HGCalMapping/2/47450/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89bd7c/47450/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89bd7c/47450/git-merge-result

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 4.774.77_ZElSkim2012D/step2_ZElSkim2012D.log

Comparison Summary

Summary:

@pfs
Copy link
Contributor Author

pfs commented Aug 26, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89bd7c/47863/summary.html
COMMIT: c2821e1
CMSSW: CMSSW_15_1_X_2025-08-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/Geometry-HGCalMapping/2/47863/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4113272
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4113214
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@pfs
Copy link
Contributor Author

pfs commented Aug 26, 2025

ok the previous failure seems like a temporary fluke
@smuzaffar can this be merged please?

@pfs
Copy link
Contributor Author

pfs commented Aug 26, 2025

+1

@pfs
Copy link
Contributor Author

pfs commented Aug 26, 2025

@bsunanda, @civanch, @kpedro88, @Moanwar can we get also the signatures for geometry and upgrade on this one? thanks

@bsunanda
Copy link

+geometry

@Moanwar
Copy link

Moanwar commented Aug 27, 2025

+Upgrade

@iarspider
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@iarspider iarspider merged commit 9935bd4 into cms-data:main Aug 27, 2025
10 checks passed
@pfs
Copy link
Contributor Author

pfs commented Aug 27, 2025

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants