-
Notifications
You must be signed in to change notification settings - Fork 8
Update with latest mapping of remaining partials #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new Pull Request was created by @pfs for branch main. @Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @iarspider, @kpedro88, @makortel, @mdhildreth, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
assign hgcal-dpg |
|
New categories assigned: hgcal-dpg @cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
Pull request #2 was updated. |
|
We have found out a typo in some of the rows and updated the PR |
|
can this be merged please? |
|
@pfs , is there any CMSSW PR to go along with this? |
|
test parameters:
|
|
@pfs , I see that this data file is mentioned in |
|
Can this be merged ? This maps the last Si wafers that we start having to commission in the lab. It would be great to have this by default in CMSSW |
I thought I had answered - apologies. There are not yet test/relval samples. We are preparing the pull requests needed to enable one workflow making use of these. |
|
Pull request #2 was updated. |
|
please test |
|
likewise for #3 can this PR be merged? I need it to start defining a workflow in CMSSW so that it starts to be used regularly (this PR defines the readout of all Si modules which are expected in geometry). We have tested the usage of this (and the file of #3) during the 18th Hackathon (the results of slides 14-34 of the "final scrum" relied implicitly on these files). Thanks! |
|
+1 |
|
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here:
RelVals-INPUT
Comparison SummarySummary:
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89bd7c/47863/summary.html Comparison SummarySummary:
|
|
ok the previous failure seems like a temporary fluke |
|
+1 |
|
+geometry |
|
+Upgrade |
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
thank you! |
This PR adds the remaining partials to the Si wafer map for HGCAL.
@cseez : with respect to the original file I just changed WType to Typecode in the original file as this how it's currently used in CMSSW.