add calibration-to-surrounding cell offset map

[RSalvatico]

PR description

Add HGCAL calibration-to-surrounding cell offset map, based on the tables in this document.

[cmsbuild]

A new Pull Request was created by @RSalvatico for branch main.

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @iarspider, @kpedro88, @makortel, @mdhildreth, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[RSalvatico]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a8261/45473/summary.html
COMMIT: c16aeb6
CMSSW: CMSSW_15_1_X_2025-04-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/Geometry-HGCalMapping/3/45473/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 15 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3916361
• DQMHistoTests: Total failures: 38
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3916303
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #3 was updated.

[RSalvatico]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a8261/45915/summary.html
COMMIT: dde80e7
CMSSW: CMSSW_15_1_X_2025-05-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/Geometry-HGCalMapping/3/45915/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4037687
• DQMHistoTests: Total failures: 41
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4037626
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #3 was updated.

[RSalvatico]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a8261/45993/summary.html
COMMIT: 4ee99b8
CMSSW: CMSSW_15_1_X_2025-05-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/Geometry-HGCalMapping/3/45993/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Subsystem HLTrigger built
>> Subsystem Utilities built
Copying tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1886: tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreROCmAsync/libRecoTrackerLSTCoreROCmAsync_rocm.a] Error 1
Copying tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1886: tmp/el8_amd64_gcc12/src/RecoTracker/LSTCore/src/alpaka/RecoTrackerLSTCoreCudaAsync/libRecoTrackerLSTCoreCudaAsync_nv.a] Error 1
>> Entering Package Configuration/Skimming


[RSalvatico]

Not sure what was wrong here, so I'll just try to trigger the tests again

[RSalvatico]

please test

[smuzaffar]

Not sure what was wrong here, so I'll just try to trigger the tests again

The last PR tests used an IB where RecoTracker/LSTCore had incomplete changes. This has been fixed and PR tests should work now

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a8261/46048/summary.html
COMMIT: 4ee99b8
CMSSW: CMSSW_15_1_X_2025-05-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/Geometry-HGCalMapping/3/46048/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw SCRAMV1: fix typo in scramfatal message cms-sw/cmsdist#9847

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a8261/46048/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a8261/46048/git-merge-result

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4038131
• DQMHistoTests: Total failures: 795
• DQMHistoTests: Total nulls: 32
• DQMHistoTests: Total successes: 4037284
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 37.904 KiB( 49 files compared)
• DQMHistoSizes: changed ( 145.014,... ): 4.246 KiB L1TEMU/L1TdeStage2EMTF
• DQMHistoSizes: changed ( 145.014,... ): 0.492 KiB L1T/L1TStage2uGT
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[RSalvatico]

Hello. The txt file added by this PR is needed for this cms-sw PR to work properly. It won't break any "central" workflow if it's not integrated before the cms-sw PR, but there are some HGCAL testing workflows that won't work out of the box if it doesn't happen. So it would be good to get signatures or comments. Thanks!

[IzaakWN]

Hi all, is there anything needed before this PR can be merged?

(Apologies if I'm being pushy, but this would facilitate HGCal development.)

[pfs]

Hi, as cms-sw/cmssw#47829 is merged, can this be merged as well please?

[Moanwar]

+Upgrade

[RSalvatico]

Hello,
This PR has been open since nearly two months and has received zero comments on the content -- which evidently is not particularly controversial, nor can do any harm if merged. Can we please get the necessary signatures (or comments, if any)?

[smuzaffar]

+externals