Skip to content

Updating SiPM mapping for 30 degree sectors#5

Merged
smuzaffar merged 1 commit intocms-data:mainfrom
kerstinlovisa:hgcalmapping_SiPMupdate
Aug 5, 2025
Merged

Updating SiPM mapping for 30 degree sectors#5
smuzaffar merged 1 commit intocms-data:mainfrom
kerstinlovisa:hgcalmapping_SiPMupdate

Conversation

@kerstinlovisa
Copy link
Copy Markdown

Updated SiPM channel map for channels on tileboards mapped in a complete 10 degree sector, including new typecodes.

Updated channel mapping of the SiPM tileboards, with:

  • new mapping of channels mapped over 3 x 10-degree sectors (with global iring and new local iphi)
  • new typecodes
  • high and low-density tileboards

The new channel mapping logic was presented during the DPG session of the last HGCal Workshop here.

This PR is made together with another PR to cmssw: 48571

Validation of known input pixel arts was done 2 times, first with a known issue in the input (making the output misspelled with correct mapping):
HGCal_mapping_validation
Secondly with fixed error in the input and more variation in ADC input values for even better validation:
HGCal_mapping_validation2
(Note that rotation of SiPM tileboards is not yet implemented in DQM)

@pfs @jniedzie @jalimena

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @kerstinlovisa for branch main.

@Dr15Jones, @Moanwar, @akritkbehera, @bsunanda, @civanch, @cmsbuild, @iarspider, @kpedro88, @makortel, @mdhildreth, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jul 18, 2025

cms-bot internal usage

@pfs
Copy link
Copy Markdown
Contributor

pfs commented Jul 18, 2025

please test

@pfs
Copy link
Copy Markdown
Contributor

pfs commented Jul 18, 2025

Note for reviewers: like for #2 this PR was long expected, to have the final mapping of the SiPM-on-tile compartment of HGCal which is needed for cassette assembly @ FNAL

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a43837/47271/summary.html
COMMIT: 56e8362
CMSSW: CMSSW_15_1_X_2025-07-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/Geometry-HGCalMapping/5/47271/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4076521
  • DQMHistoTests: Total failures: 116
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4076385
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@IzaakWN
Copy link
Copy Markdown

IzaakWN commented Jul 24, 2025

Hi all, @smuzaffar, is anything needed for this PR, or can it be merged, please?

Sorry to push, but we need it for PR cms-sw/cmssw#48571 in time for the cassette testing in September.

@IzaakWN
Copy link
Copy Markdown

IzaakWN commented Aug 5, 2025

Hi @smuzaffar, is anything needed for this PR, or can it be merged, please?

@Moanwar
Copy link
Copy Markdown

Moanwar commented Aug 5, 2025

+Upgrade

@smuzaffar
Copy link
Copy Markdown
Contributor

@IzaakWN , I do not see any ref to this data file in cms-sw/cmssw#48571 so I do not understand how cmssw PR depends on it?

From the externals point of view, I am no objections on signing it but want to make sure that we add data file which is really used.

@smuzaffar
Copy link
Copy Markdown
Contributor

+externals

ah I see that file is references here https://github.com/cms-sw/cmssw/blob/master/Geometry/HGCalMapping/python/hgcalmapping_cff.py#L6

@smuzaffar
Copy link
Copy Markdown
Contributor

@bsunanda, @civanch, @kpedro88, if no objections then can you please sign it for geometry?

@mandrenguyen
Copy link
Copy Markdown

+1

@smuzaffar smuzaffar merged commit d3ce5cc into cms-data:main Aug 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants