Skip to content

ThePEG: Removed inlined Particle::parents()#10554

Merged
smuzaffar merged 1 commit into
IB/CMSSW_17_0_X/masterfrom
thepeg-fix-particle-parent
May 13, 2026
Merged

ThePEG: Removed inlined Particle::parents()#10554
smuzaffar merged 1 commit into
IB/CMSSW_17_0_X/masterfrom
thepeg-fix-particle-parent

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

@smuzaffar smuzaffar commented May 13, 2026 •
edited
Loading

Following suggestion at cms-sw/cmssw#45872 , this PR proposes to patch thepeg and move inlined Particle::parent() in to the source file.

Fixes cms-sw/cmssw#45872

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 13, 2026

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 13, 2026 •
edited
Loading

cms-bot internal usage

@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented May 13, 2026

please test workflow 537.0,538.0

@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented May 13, 2026

please test workflow 537.0,538.0 for CMSSW_17_0_CLANG_X

@smuzaffar smuzaffar changed the title patched thepeg: Removed inlines Particle::parent ThePEG: Removed inlines Particle::parent May 13, 2026
@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented May 13, 2026 •
edited
Loading

test parameters:

  • enable = threading
  • relvals = 537.0,538.0
  • relvals_threading = 537.0,538.0

@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented May 13, 2026

please test for CMSSW_17_0_CLANG_X

@smuzaffar smuzaffar changed the title ThePEG: Removed inlines Particle::parent ThePEG: Removed inlined Particle::parents() May 13, 2026
@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented May 13, 2026

please test for CMSSW_17_0_CLANG_X

@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented May 13, 2026

please test

lets run default tests in threaded mode too

@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented May 13, 2026

this indeed has fixed the failing clang relvals

++ runTheMatrix.py -j 5 --job-reports -i all -t 4 -l 537.0,538.0 --command ' --prefix "timeout --signal SIGTERM 9000" --customise Validation/Performance/TimeMemoryJobReport.customiseWithTimeMemoryJobReport '
 537.0_DYToLL012Jets_5FS_TuneCH3_13TeV_amcatnloFxFx_herwig7 Step0-PASSED Step1-PASSED  - time date Wed May 13 16:39:42 2026-date Wed May 13 16:36:50 2026; exit: 0 0
538.0_DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7 Step0-PASSED Step1-PASSED  - time date Wed May 13 16:40:41 2026-date Wed May 13 16:36:50 2026; exit: 0 0
2 2 tests passed, 0 0 failed

@smuzaffar smuzaffar mentioned this pull request May 13, 2026
Closed
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 13, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a22de/53235/summary.html
COMMIT: 0354fa2
CMSSW: CMSSW_17_0_X_2026-05-12-2300/el8_amd64_gcc13
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10554/53235/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a22de/53235/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a22de/53235/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4189044
  • DQMHistoTests: Total failures: 522
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4188502
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 231 log files, 201 edm output root files, 55 DQM output files
  • TriggerResults: found differences in 6 / 53 workflows

@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented May 13, 2026

+externals

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 13, 2026

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit d6d2c57 into IB/CMSSW_17_0_X/master May 13, 2026
16 of 17 checks passed
@smuzaffar smuzaffar deleted the thepeg-fix-particle-parent branch May 13, 2026 20:56
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 13, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a22de/53232/summary.html
COMMIT: 0354fa2
CMSSW: CMSSW_17_0_CLANG_X_2026-05-12-2300/el8_amd64_gcc13
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10554/53232/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a22de/53232/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a22de/53232/git-merge-result

Comparison Summary

Summary:

  • You potentially added 89 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 105426 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4189044
  • DQMHistoTests: Total failures: 558123
  • DQMHistoTests: Total nulls: 340
  • DQMHistoTests: Total successes: 3630561
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.8340000000000005 KiB( 54 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 1.235 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 17034.0 ): -3.505 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 18634.0 ): -4.216 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2022.0010001 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2023.0020001 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0010001 ): 0.031 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0020001 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0030001 ): -0.039 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0040001 ): 0.078 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0050001 ): ...
  • Checked 231 log files, 201 edm output root files, 55 DQM output files
  • TriggerResults: found differences in 20 / 53 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

externals-approved fully-signed orp-pending tests-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CLANG_X] Segmentation violation in ThePEG::EventGenerator::doinit

2 participants

@smuzaffar @cmsbuild