Skip to content

Remove obsolte python directory.#10555

Merged
smuzaffar merged 1 commit into
IB/CMSSW_17_0_X/masterfrom
python-cleanup
May 13, 2026
Merged

Remove obsolte python directory.#10555
smuzaffar merged 1 commit into
IB/CMSSW_17_0_X/masterfrom
python-cleanup

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

Dependabot now also reads setup.py files and generate security alerts . We have this very old (over 9 year) python directory for build pip packages but we do not use it any more. Due to this Dependabot has generated over 500 security alerts. This PR proposes to drop this unused directory

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 13, 2026

cms-bot internal usage

@smuzaffar
Copy link
Copy Markdown
Contributor Author

+externals

externals build without any errors so this python directory is not used in any way. Merging this shoudl resolve the over 500 Dependabot reported issues

@smuzaffar smuzaffar merged commit 87df93f into IB/CMSSW_17_0_X/master May 13, 2026
6 of 7 checks passed
@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f400a7/53226/summary.html
COMMIT: 028541e
CMSSW: CMSSW_17_0_X_2026-05-12-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10555/53226/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f400a7/53226/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f400a7/53226/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4187168
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4187116
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 6 / 51 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants