Conversation
Contributor
Greptile SummaryImplements the new hs.mouse JavaScript module.
Confidence Score: 4/5The tracking-speed input validation defect should be fixed before merging because user scripts can persist unsupported mouse acceleration values. The module is wired consistently with existing JavaScriptCore modules, but setTrackingSpeed forwards and persists every bridged Double despite publicly restricting the value to a finite -1.0 through 3.0 range. Hammerspoon 2/Modules/hs.mouse/HSMouseModule.swift Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
Hammerspoon 2/Modules/hs.mouse/HSMouseModule.swift:325-337
**Invalid tracking speeds are persisted**
When JavaScript passes a value outside the documented -1.0 through 3.0 range, including NaN or Infinity, the setter forwards it unchanged to IOKit and persists it to `com.apple.mouse.scaling`, causing invalid or inconsistent live and persisted mouse settings.
Reviews (1): Last reviewed commit: "Implement hs.mouse. Closes #129" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.