Mix respondent weights for all indicators #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good; will officially approve once the tests are ready after the other merge. |
nmdefries
force-pushed
the
survey-comprehensive-mixing
branch
from
00bc2c4 to
873de82
Compare
Contributor
Author
|
These changes should be added to #1065 so the backfill includes both the standard error definition update and the weight-mixing update. |
Contributor
Author
|
@capnrefsmmat Test files are updated, so this is ready to look at again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mix weights for all indicators, and remove the
skip_mixingflag.Note: This change requires that we regenerate gold receiving files (sincevals and thusses are calculated differently for a subset of signals). Wait until #1065 is merged to finish this so we can regenerate gold receiving files with both sets of changes included.Changelog
aggregate.Randcontingency_aggregate.R: remove logic that allows indicators to select whether or not to use mixing.contingency_utils.R,binary.R, andcount.R: stop settingskip_mixingflag for indicators.vals and thusses are calculated differently for a subset of signals.Fixes
Closes #764.