added design feature #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sei-aschlackman
commented
Apr 4, 2022
sei-aschlackman
commented
- a directory can have one or more designs
- a design can have variables and modules
- designs are converted into terraform upon a workspace run
- a directory can have one or more designs - a design can have variables and modules - designs are converted into terraform upon a workspace run
sei-aschlackman
requested review from
sei-chershberger,
sei-noconnor and
sei-tspencer
as code owners
|
This pull request introduces 4 alerts when merging 69341f1 into 84e4fed - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging f9998a8 into 84e4fed - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging d946b11 into 84e4fed - view on LGTM.com new alerts:
|
sei-tspencer
reviewed
Apr 4, 2022
| /// <summary> | ||
| /// keep track of changes across multiple savechanges in a transaction, without duplicates | ||
| /// </summary> | ||
| private void SaveEntries() |
Contributor
There was a problem hiding this comment.
This is very cool. I like it!
sei-tspencer
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.