Skip to content

fix default value formatting for objects #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sei-aschlackman merged 2 commits into from
Jun 29, 2022
Merged

fix default value formatting for objects #42

sei-aschlackman merged 2 commits into from
Jun 29, 2022

Conversation

@sei-aschlackman
Copy link
Contributor

@sei-aschlackman sei-aschlackman commented Jun 29, 2022

  • temporary workaround until we parse HCL directly

@sei-aschlackman
fix default value formatting for objects
6b68206 
- temporary workaround until we parse HCL directly
@lgtm-com
Copy link

lgtm-com bot commented Jun 29, 2022

This pull request introduces 2 alerts when merging 6b68206 into 38dcf0a - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Poor error handling: empty catch block

@sei-aschlackman sei-aschlackman merged commit cfe91fc into development Jun 29, 2022
@sei-aschlackman sei-aschlackman deleted the bugfix/default-module-value branch June 29, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sei-tspencer sei-tspencer Awaiting requested review from sei-tspencer

@sei-chershberger sei-chershberger Awaiting requested review from sei-chershberger

@sei-noconnor sei-noconnor Awaiting requested review from sei-noconnor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sei-aschlackman