Conversation
Signed-off-by: Ender Demirkaya <enderd@uber.com>
Signed-off-by: Ender Demirkaya <enderd@uber.com>
Signed-off-by: Ender Demirkaya <enderd@uber.com>
Signed-off-by: Ender Demirkaya <enderd@uber.com>
Signed-off-by: Ender Demirkaya <enderd@uber.com>
76bcc52 to
b938705
Compare
nate-double-u
left a comment
There was a problem hiding this comment.
Hi, thanks for this @demirkayaender.
I'm not sure why the colour and black versions of the horizontal logo are different, but if you're not going to go with an actual colour version of it, I'd choose the cadence-horizontal-black.png version as it's a cleaner image.
I do recommend developing a colour set of logos though. If you'd like, we can have our design team help with this.
|
@nate-double-u , thanks for catching this! I haven't realized the black horizontal version was using bold letters. I will send an update for the others using the same format. Color one isn't really used, we typically use black (most common) or the white one. How about we land consistent sets after my change for now? After then, we'd appreciate getting some help with the color ones. |
|
Sounds good! When you're ready for color, open a support desk ticket and we'll be happy to help out. We can keep this update separate from that one. |
Signed-off-by: Ender Demirkaya <enderd@uber.com>
nate-double-u
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the update @demirkayaender!
Changes can be viewed here: https://github.com/demirkayaender/artwork/blob/cadence-artwork/examples/sandbox_a-j.md#cadence-logos
Pre-submission checklist:
If you're adding a new project to the repo, please confirm each of these actions has been completed:
Note: Updates to this repo require two approvals to be merged in. One from a CNCF staff member, and the other from a project maintainer whose project's artwork is being updated. We can bypass branch protections for PRs made by maintainers.