Skip to content

fixed(socks5): typo ProxySocks4 on socks5:// - #101

Merged
cnlangzi merged 1 commit into
mainfrom
fix(socks5)-fix-type-on-socks5-support
Jun 20, 2026
Merged

fixed(socks5): typo ProxySocks4 on socks5://#101
cnlangzi merged 1 commit into
mainfrom
fix(socks5)-fix-type-on-socks5-support

Conversation

@cnlangzi

@cnlangzi cnlangzi commented Jun 20, 2026

Copy link
Copy Markdown
Owner

fixed: #100

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.37%. Comparing base (b5f43d8) to head (d4f213f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   18.88%   19.37%   +0.49%     
==========================================
  Files          29       29              
  Lines        1827     1827              
==========================================
+ Hits          345      354       +9     
+ Misses       1449     1436      -13     
- Partials       33       37       +4     
Flag Coverage Δ
Tests 19.37% <100.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cnlangzi
cnlangzi merged commit 4abed3c into main Jun 20, 2026
7 checks passed
@cnlangzi
cnlangzi deleted the fix(socks5)-fix-type-on-socks5-support branch June 20, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does the ProxySocks4 implementation support SOCKS5?

1 participant