fix: populate topic author in message list - #6
Merged
Conversation
GET /messages always returned the empty placeholder for topic.author because getMessageRelations handed back a raw topic row that has no author relation; the messageDTOSchema contract declares a real author and the route test mocked one, hiding the gap. Fetch the topic author in getMessageRelations and attach it, so the web message list can show who owns the topic. Covered by the new message-relations test, which fails against the previous implementation.
fengmk2
force-pushed
the
populate-message-topic-author
branch
from
August 5, 2026 07:55
f5c0a76 to
ddca2f8
Compare
fengmk2
marked this pull request as ready for review
August 5, 2026 08:35
thonatos
approved these changes
Aug 5, 2026
thonatos
left a comment
thonatos
left a comment
Member
There was a problem hiding this comment.
Review: LGTM
补拉 topic.author 并挂载，路由端正确消费；测试覆盖 topic 存在/缺失两路，vi.hoisted mock 规范。
非阻塞：每条消息查询由 2 次变 3 次（原有 N+1 上加 1），消息列表页量级可接受，后续可批量 fetch 优化。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenSpec
<!-- change name -->Verification
pnpm verifypassed.<!-- commands -->because<!-- reason -->.Impact Checklist
apps/,packages/)apps/api/src/routes/*.tszod-openapi declarations,api/openapi.jsonviapnpm gen:openapi)packages/db)deployment/)README.md,docs/,wiki/).github/workflows/,scripts/,package.json).env, tokens, cookies, private keys, database URLs, or user data committed.Migration / Deployment Notes