fix(scrapper): manage audio and video requests#58
Merged
Conversation
vvatelot
reviewed
Feb 22, 2024
Member
|
I am reading the #30 issue again... I think I was not completely clear 🙂 : In this case as it is a mp3 file, the analysis should return an error: We only accept to analyse html content. This is the behaviour we had in the old scraper and I did not implement it yet... So, here I think we have 2 issues:
What do you think ? |
Collaborator
Author
|
Hello @vvatelot ! Ah alright ! I will modify the code to raise an error when the url doesn't point to a text/html content type. |
vvatelot
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify get_requests_from_har_file method to take into account mp3 and audio requests.
Basically manage cases when _transferSize in the HTTP request is equal to -1.
close #30