Skip to content

WIP diff-api-snapshot danger#9

Merged
coado merged 0 commit intomainfrom
@dmalecki/diff-api-snap-danger
Jun 16, 2025
Merged

WIP diff-api-snapshot danger#9
coado merged 0 commit intomainfrom
@dmalecki/diff-api-snap-danger

Conversation

@coado
Copy link
Copy Markdown
Owner

@coado coado commented Jun 16, 2025

Summary:

Changelog:

Test Plan:

@coado
Copy link
Copy Markdown
Owner Author

coado commented Jun 16, 2025

Fails
🚫

Danger failed to run dangerfile.js.

Error ReferenceError

Cannot access 'idea' before initialization
ReferenceError: Cannot access 'idea' before initialization
    at Object.<anonymous> (dangerfile.js:32:317)
    at Module._compile (node:internal/modules/cjs/loader:1730:14)
    at requireFromString (/home/runner/work/react-native/react-native/node_modules/require-from-string/index.js:28:4)
    at /home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:183:68
    at step (/home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:56:23)
    at Object.next (/home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:37:53)
    at /home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:31:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:27:12)
    at runDangerfileEnvironment (/home/runner/work/react-native/react-native/node_modules/danger/distribution/runner/runners/inline.js:123:132)
    at /home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:181:38
    at step (/home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:44:23)
    at Object.next (/home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:25:53)
    at /home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:19:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:15:12)
    at Object.executeRuntimeEnvironment (/home/runner/work/react-native/react-native/node_modules/danger/distribution/platforms/GitHub.js:144:88)
    at /home/runner/work/react-native/react-native/node_modules/danger/distribution/commands/danger-runner.js:101:47
    at step (/home/runner/work/react-native/react-native/node_modules/danger/distribution/commands/danger-runner.js:34:23)
    at Object.next (/home/runner/work/react-native/react-native/node_modules/danger/distribution/commands/danger-runner.js:15:53)
    at fulfilled (/home/runner/work/react-native/react-native/node_modules/danger/distribution/commands/danger-runner.js:6:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

Dangerfile

27| 
28| const isFromPhabricator = body_contains('differential revision:');
29| 
30| // Provides advice if a summary section is missing, or body is too short
31| const includesSummary = body_contains('## summary', 'summary:');
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------^
32| 
33| const snapshot_output = JSON.parse(fs.readFileSync(path.join(process.env.RUNNER_TEMP, 'snapshot/output.json'), 'utf8'));
34| if (snapshot_output && snapshot_output.result !== "NON_BREAKING") {
35|   const title = ':exclamation: Javascript API change detected';

Generated by 🚫 dangerJS against a220707

@coado coado merged this pull request into main Jun 16, 2025
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant