Skip to content

feat(aurora): add badge support to ContentHeader#981

Merged
TilmanHaupt merged 1 commit into
mainfrom
til-contentheader-badge
Jun 29, 2026
Merged

feat(aurora): add badge support to ContentHeader#981
TilmanHaupt merged 1 commit into
mainfrom
til-contentheader-badge

Conversation

@TilmanHaupt

@TilmanHaupt TilmanHaupt commented Jun 29, 2026

Copy link
Copy Markdown
Member

Add badges prop to ContentHeader component that displays on the left side of the actions row (below the divider). Also add mb-8 margin to header for consistent spacing.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

Summary by CodeRabbit

  • New Features
    • Added badge support to content headers, allowing badges to appear alongside header actions.
    • Updated header spacing for a more consistent layout across the app.

Add badges prop to ContentHeader component that displays on the left side of the actions row (below the divider). Also add mb-8 margin to header for consistent spacing.
@TilmanHaupt TilmanHaupt requested a review from a team as a code owner June 29, 2026 13:04
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

ContentHeader gains an optional badges prop (ReactNode). The header element now uses mb-8. The actions-only render block is replaced with a conditional row showing badges on the left and actions on the right when either is present. A minor changeset is added.

Changes

ContentHeader Badge Support

Layer / File(s) Summary
badges prop, layout, and changeset
packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx, .changeset/badge-support-contentheader.md
ContentHeaderProps adds badges?: ReactNode; the function destructures it; <header> gets className="mb-8"; the actions block becomes a conditional (badges || actions) row with badges left and actions right; a minor changeset records the release.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • hgw77
  • vlad-schur-external-sap

Poem

🐇 A badge on the left, an action on the right,
The ContentHeader shines with margins just right.
mb-8 keeps spacing neat and true,
A tiny prop addition — hoppity-hoo!
The changelog is filed, the bunny is done. 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too sparse and omits required template sections like Summary, Changes Made, Related Issues, and Testing Instructions. Add the missing template sections with a short summary, change list, related issue links, screenshots if relevant, and explicit testing steps.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding badge support to ContentHeader.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch til-contentheader-badge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TilmanHaupt TilmanHaupt enabled auto-merge (squash) June 29, 2026 13:06

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx`:
- Around line 49-54: The conditional rendering in ContentHeader should use
presence checks instead of truthiness so valid ReactNode values like 0 are not
dropped. Update the badges/actions block in ContentHeader to test whether badges
or actions are actually provided, and only render the left badges wrapper when
badges exists so actions-only content doesn’t produce an empty container.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 27925662-fa75-46ad-a00e-34d7729711df

📥 Commits

Reviewing files that changed from the base of the PR and between 582e7ef and 93d2faf.

📒 Files selected for processing (2)
  • .changeset/badge-support-contentheader.md
  • packages/aurora/src/client/components/ContentHeader/ContentHeader.tsx

@TilmanHaupt TilmanHaupt merged commit 8689aa9 into main Jun 29, 2026
28 checks passed
@TilmanHaupt TilmanHaupt deleted the til-contentheader-badge branch June 29, 2026 13:11
@coderabbitai coderabbitai Bot mentioned this pull request Jun 29, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants