Skip image property filtering for internal scheduling intents#1078
Merged
Conversation
PhilippMatthes
requested review from
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
July 23, 2026 08:42
This comment was marked as spam.
This comment was marked as spam.
Signed-off-by: Philipp Matthes <p.matthes@sap.com>
PhilippMatthes
force-pushed
the
skip-filter-image-properties-intent-based
branch
from
July 23, 2026 08:48
ddc8abb to
8e41b92
Compare
PhilippMatthes
changed the title
PhilippMatthes
force-pushed
the
skip-filter-image-properties-intent-based
branch
from
July 23, 2026 08:53
27d40d8 to
ddc8abb
Compare
juliusclausnitzer
approved these changes
Jul 23, 2026
Signed-off-by: Philipp Matthes <p.matthes@sap.com>
PhilippMatthes
force-pushed
the
skip-filter-image-properties-intent-based
branch
from
July 23, 2026 08:57
8e41b92 to
b96286d
Compare
Contributor
Test Coverage ReportTest Coverage 📊: 70.3% |
juliusclausnitzer
approved these changes
Jul 23, 2026
Merged
umswmayj
added a commit
that referenced
this pull request
Jul 23, 2026
## Release cortex 0.3.3 ## 2026-07-23 — [#1080](#1080) ### cortex v0.3.3 (sha-4eba8400) Non-breaking changes: - Skip image property filtering for internal scheduling intents — the FilterImageProperties Nova scheduling filter now skips image-property-based filtering for Cortex-internal intents (reserve_for_failover, reuse_failover_reservation, reserve_for_committed_resource, capacity_probe) which schedule based on flavor metadata independent of the image ([#1078](#1078)) - Bump `google.golang.org/grpc` from 1.82.0 to 1.82.1 — security patch addressing HTTP/2 flood protection and xds/rbac fixes ([#1079](#1079)) ### cortex-shim v0.1.9 (sha-378ee2f5) Includes updated image sha-378ee2f5. ### cortex-postgres v0.6.11 (sha-e06153f8) Includes updated image sha-e06153f8. ### cortex-nova v0.0.83 Includes updated charts cortex v0.3.3, cortex-postgres v0.6.11. ### cortex-cinder v0.0.83 Includes updated charts cortex v0.3.3, cortex-postgres v0.6.11. ### cortex-manila v0.0.83 Includes updated charts cortex v0.3.3, cortex-postgres v0.6.11. ### cortex-crds v0.0.83 Includes updated chart cortex v0.3.3. ### cortex-ironcore v0.0.83 Includes updated chart cortex v0.3.3. ### cortex-pods v0.0.83 Includes updated chart cortex v0.3.3. ### cortex-placement-shim v0.1.9 Includes updated chart cortex-shim v0.1.9. ## Dependencies - Prep PR: #1083 (must be merged before this PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FilterImageProperties Nova scheduling filter now skips image-property-based filtering for the Cortex-internal scheduling intents reserve_for_failover, reuse_failover_reservation, reserve_for_committed_resource, and capacity_probe, returning all hosts unchanged. These internal intents schedule based on flavor metadata and are independent of the image that eventually lands on the host, so image metadata is not expected to be set for them. Applying image-property filtering in those cases would incorrectly exclude hosts. The create intent continues to filter as before, and the unit tests were extended with a requestWithIntent helper and cases covering each skipped intent as well as a create intent that still filters known kvm hypervisors.
Bonus: this also adjusts the pr-creator agent to sign-off on commits.
Assisted-by: Claude Code:claude-opus-4-1-20250805 [Bash]