feat(loop-worktree): expose public lock API - #407
Merged
cobusgreyling merged 1 commit intoJul 29, 2026
Conversation
shixi-li
force-pushed
the
codex/public-loop-worktree-lock
branch
from
July 29, 2026 09:10
64942cb to
52476ed
Compare
shixi-li
marked this pull request as ready for review
July 29, 2026 09:11
Contributor
Author
|
Rebased this PR onto current The rebase was conflict-free, and Validation on the rebased head
This follows the maintainer's explicit invitation on #399 for a public Ready for maintainer review. |
cobusgreyling
approved these changes
Jul 29, 2026
cobusgreyling
left a comment
Owner
There was a problem hiding this comment.
Review
Clean package-contract PR for the advisory lock coordinator:
- Public
@cobusgreyling/loop-worktree/lockexport map +typesVersions - Tests import via the public subpath; new pack/export test covers the contract
- README documents the stable entry point
- Version bump 1.2.0 → 1.3.0 + RELEASE_NOTES_DRAFT publish note
- Scope correctly defers
loop-sandboximport migration
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose the advisory lock coordinator through the supported
@cobusgreyling/loop-worktree/locksubpath, following the explicit follow-upwelcomed in #399.
Why
loop-sandboxcurrently reaches into@cobusgreyling/loop-worktree/dist/lock.js. That private build path makesconsumers depend on package layout rather than a public contract. This PR
establishes the package contract without changing lock runtime behavior.
The
loop-sandboximport migration is intentionally deferred untilloop-worktree@1.3.0is published and #398 has settled, avoiding across-package release dependency and overlapping changes.
Changes
./lockconditional exports with declaration mappings./dist/*and./package.jsoncompatibility exportstypesVersionssupport for classic TypeScript module resolutionloop-worktreeto 1.3.0, align the previously stale lockfile, andupdate the publish checklist
imports, and NodeNext/classic TypeScript resolution
the full declared Node 18 range
Scope
This PR does not modify
loop-sandbox, manifest concurrency, or the open #398work.
Validation
cd tools/loop-worktree && npm test— 32/32 passedcd tools/loop-audit && npm run build && node dist/cli.js ../..— 100/100 L3git diff --checkFollow-up to #399.