-
Notifications
You must be signed in to change notification settings - Fork 4.1k
geo/geomfn: implement ST_Split({geometry,geometry}) #49045
Copy link
Copy link
Open
Labels
A-geometry-builtinsBuiltins which have geometry as args.Builtins which have geometry as args.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)X-nostaleMarks an issue/pr that should be ignored by the stale botMarks an issue/pr that should be ignored by the stale bot
Metadata
Metadata
Assignees
Labels
A-geometry-builtinsBuiltins which have geometry as args.Builtins which have geometry as args.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)X-nostaleMarks an issue/pr that should be ignored by the stale botMarks an issue/pr that should be ignored by the stale bot
Implement
ST_Spliton arguments {geometry,geometry}, which should adopt PostGIS behaviour.Observers: Please react to this issue if you need this functionality.
For Geometry builtins, please do the following:
pkg/geo/geomfn(parse and output related functions can go inpkg/geo). Add exhaustive unit tests here - you can run through example test cases and make sure that PostGIS and CRDB return the same result within a degree of accuracy (1cm for geography).pkg/sql/sem/builtins/geo_builtins.go. Note that we currently do not support optional arguments, so we define functions that have optional arguments once without the optional argument (using the default value in the optional position), and once with the optional argument.pkg/sql/logictest/testdata/logic_test/geospatialto call this functionality at least once. You can callmake testbaselogic FILES='geospatial' TESTFLAGS='-rewrite'to regenerate the output. Tests here should just ensure the builtin is linked end to end (your exhaustive unit tests go the above mentioned packages!).make buildshort. You can also play with it by calling./cockroach demo --emptyafterwards.You can follow #48552 for an example PR.
🤖 This issue was synced with a spreadsheet by gsheets-to-github-issues by otan on 2023-09-03T23:16:38Z. Changes to titles, body and labels may be overwritten.