storage: set minLeaseTransferInterval to 1s#11729
Merged
petermattis merged 1 commit intocockroachdb:masterfrom Nov 30, 2016
Merged
storage: set minLeaseTransferInterval to 1s#11729petermattis merged 1 commit intocockroachdb:masterfrom
petermattis merged 1 commit intocockroachdb:masterfrom
Conversation
The recent change to GossipStoresInterval from 5s to 60s slowed lease transfers down too much. Now that store gossiping is reactive (and thus occurs at varying frequency) we can't easily base minLeaseTransferInterval on it.
Contributor
|
does this want to be tunable via env now that it isn't pegged to anything? |
Collaborator
Author
|
I'm not sure. I don't have any other plans to tweak this and an env setting wouldn't have precluded a change here. Lease rebalance throttling might deserve a different mechanism. I should probably check to see whether the reactive gossip is sufficient. |
Contributor
|
OK, LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent change to GossipStoresInterval from 5s to 60s slowed lease
transfers down too much. Now that store gossiping is reactive (and thus
occurs at varying frequency) we can't easily base
minLeaseTransferInterval on it.
This change is