Skip to content

RFC: pushing down filters for joins#12430

Merged
RaduBerinde merged 1 commit into
cockroachdb:masterfrom
RaduBerinde:join-filter-rfc
Dec 19, 2016
Merged

RFC: pushing down filters for joins#12430
RaduBerinde merged 1 commit into
cockroachdb:masterfrom
RaduBerinde:join-filter-rfc

Conversation

@RaduBerinde
Copy link
Copy Markdown
Member

@RaduBerinde RaduBerinde commented Dec 15, 2016

This change is Reviewable

@RaduBerinde RaduBerinde requested a review from knz December 15, 2016 22:45
Comment thread docs/RFCS/join_filters.md Outdated

## LEFT OUTER JOIN

In a left outer join, all rows from the left table ends up in the output in some
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ends/end/

Comment thread docs/RFCS/join_filters.md Outdated
- `filterLeft` can be pushed down to `l`:
```sql
SELECT * FROM
(SELECT * from l WHERE onLeft) JOIN r
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/onLeft/filterLeft/

@RaduBerinde
Copy link
Copy Markdown
Member Author

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


docs/RFCS/join_filters.md, line 56 at r1 (raw file):

Previously, spencerkimball (Spencer Kimball) wrote…

s/ends/end/

Done, thanks.


docs/RFCS/join_filters.md, line 78 at r1 (raw file):

Previously, spencerkimball (Spencer Kimball) wrote…

s/onLeft/filterLeft/

Done.


Comments from Reviewable

@RaduBerinde
Copy link
Copy Markdown
Member Author

@knz I think you looked over this, ok to merge?

@knz
Copy link
Copy Markdown
Contributor

knz commented Dec 19, 2016

yes LGTM

@RaduBerinde RaduBerinde merged commit 81533e4 into cockroachdb:master Dec 19, 2016
@RaduBerinde RaduBerinde deleted the join-filter-rfc branch December 19, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants