cli: fix parsing bugs in encode-uri#132299
Open
stevendanna wants to merge 1 commit intocockroachdb:masterfrom
Open
cli: fix parsing bugs in encode-uri#132299stevendanna wants to merge 1 commit intocockroachdb:masterfrom
stevendanna wants to merge 1 commit intocockroachdb:masterfrom
Conversation
The command as documented makes the scheme optional. Unfortunately, when parsing without a scheme we had two bugs: (1) our attempt to add a scheme added the scheme separate into the scheme name and (2) certain combinations of components could easily be parsed incorrectly: ``` > ./cockroach-v24.3.0-alpha.1.darwin-11.0-arm64/cockroach encode-uri foo postgresql://://root@defaultdb?options=-ccluster%3Dsystem > ./cockroach-v24.3.0-alpha.1.darwin-11.0-arm64/cockroach encode-uri foo@bar postgresql://://root@defaultdb?options=-ccluster%3Dsystem ``` Here I've opted to look for the optional schemes we support before parsing. Another possibility is that we could make the scheme non-optional. Epic: none Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Collaborator
Author
|
Bleh, I keep intending to merge this with the other URI command and failing to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command as documented makes the scheme optional. Unfortunately, when parsing without a scheme we had two bugs: (1) our attempt to add a scheme added the scheme separate into the scheme name and (2) certain combinations of components could easily be parsed incorrectly:
Here I've opted to look for the optional schemes we support before parsing.
Another possibility is that we could make the scheme non-optional.
Epic: none
Release note: None