2025 01 31 convert store spec #140243
Draft
2025 01 31 convert store spec #140243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
andrewbaptist
force-pushed
the
2025-01-31-convert-store-spec
branch
3 times, most recently
from
fb19eb5 to
957a45d
Compare
added 2 commits
February 3, 2025 09:06
Previously the ExternalIODir was stored as a variable inside the BaseConfig struct and updated based on the StoreSpecs if it wasn't explicitly set. This commit moves it into the StorageConfig and removes it from the BaseConfig. Epic: CRDB-41111 Release note: None
This commit converts the StoreSpecs to a protobuf structure and moves it into the storagepb directory. This is now part of the StorageConfig structure. Epic: none Release note: None
andrewbaptist
force-pushed
the
2025-01-31-convert-store-spec
branch
from
957a45d to
25229c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.