mma: prototype#142138
Closed
sumeerbhola wants to merge 281 commits intocockroachdb:masterfrom
Closed
Conversation
Member
|
This change is |
sumeerbhola
commented
Feb 28, 2025
Collaborator
Author
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @kvoli)
a discussion (no related file):
The first commit is from #142002
@kvoli This depends on support in clusterState that will get added by your PR. The code here is tentative with many TODOs, some of which are trivial, some for post-protoyping, and some dependent on clarifying the semantics we want for diversity decrease. I am leaning towards this being the start of the prototyping branch since we are now starting to write non-data-structure code and much more is subject to change on how we do the integration.
sumeerbhola
commented
Feb 28, 2025
Collaborator
Author
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
Previously, sumeerbhola wrote…
The first commit is from #142002
@kvoli This depends on support in clusterState that will get added by your PR. The code here is tentative with many TODOs, some of which are trivial, some for post-protoyping, and some dependent on clarifying the semantics we want for diversity decrease. I am leaning towards this being the start of the prototyping branch since we are now starting to write non-data-structure code and much more is subject to change on how we do the integration.
@kvoli added a commit for rebalancing leases. I'll stop here until we can discuss next steps.
kvoli
reviewed
Feb 28, 2025
Contributor
kvoli
left a comment
kvoli
left a comment
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
Previously, sumeerbhola wrote…
@kvoli added a commit for rebalancing leases. I'll stop here until we can discuss next steps.
Ack, lets discuss on Monday.
sumeerbhola
force-pushed
the
mma_rebalance1
branch
from
07fd7e4 to
c587a83
Compare
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Contributor
|
Rebased to resolve conflicts. |
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
kvoli
changed the title
kvoli
force-pushed
the
mma_rebalance1
branch
2 times, most recently
from
732529c to
c4c1dcd
Compare
Contributor
|
Fixed up the last commit to resolve shadowing a var. |
kvoli
reviewed
Mar 5, 2025
kvoli
reviewed
Mar 5, 2025
kvoli
reviewed
Mar 7, 2025
kvoli
force-pushed
the
mma_rebalance1
branch
3 times, most recently
from
e66d2d5 to
ab19680
Compare
wenyihu6
force-pushed
the
mma_rebalance1
branch
5 times, most recently
from
f601840 to
f6b1501
Compare
Contributor
|
Rebased on master to pick up 607b5e5 - more in https://cockroachlabs.slack.com/archives/CJ0H8Q97C/p1743531027447729. (I show up as a co-author for everything as a result, but I didn't contribute anything 😬) |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 9, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 10, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 11, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
wenyihu6
pushed a commit
to wenyihu6/cockroach
that referenced
this pull request
Jul 12, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com> # Conflicts: # docs/generated/settings/settings.html # pkg/kv/kvserver/asim/asim.go # pkg/kv/kvserver/asim/gossip/gossip.go # pkg/kv/kvserver/asim/mmaintegration/BUILD.bazel # pkg/kv/kvserver/asim/mmaintegration/mma_store_rebalancer.go # pkg/kv/kvserver/asim/queue/lease_queue.go # pkg/kv/kvserver/asim/queue/replicate_queue.go # pkg/kv/kvserver/asim/state/BUILD.bazel # pkg/kv/kvserver/asim/state/impl.go # pkg/kv/kvserver/asim/state/state.go # pkg/kv/kvserver/asim/tests/testdata/non_rand/example_rebalancing.txt # pkg/kv/kvserver/lease_queue.go # pkg/kv/kvserver/store.go # pkg/kv/kvserver/store_gossip.go # pkg/kv/kvserver/store_gossip_test.go # pkg/kv/kvserver/stores.go
wenyihu6
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 13, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this pull request
Jul 15, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
wenyihu6
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 15, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this pull request
Jul 17, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 21, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 23, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
wenyihu6
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 29, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 30, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this pull request
Jul 31, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
wenyihu6
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 31, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
wenyihu6
added a commit
to wenyihu6/cockroach
that referenced
this pull request
Aug 3, 2025
With some package name harmonization, etc. See cockroachdb#142138 for the commit history represented in this commit. Informs cockroachdb#103320 Epic: CRDB-25222 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Informs #103320
Epic: CRDB-25222
Release note: None