workload/tpcc: add --delay-secondary-indexes flag #146859
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is effectively a revert of b52aefc. For context, long time ago (until about 20.2 version) we required that the origin side of the FK constraint had an index on the foreign key column. That requirement has been removed, yet we need to keep the support for the schema with those indexes to allow the workload to run against 20.1 and prior versions. We don't need that ability anymore, so it should be safe to delete this. Release note: None
Member
|
This change is |
We hypothesize that the secondary index build during the load phase of the IMPORT can significantly slow down the overall performance. TPCC tables have two secondary indexes, so in order to have more flexibility, this commit extends the workload with `--delay-secondary-indexes` flag which makes it so that the tables are initially created only with the primary index and the secondary indexes are created during the post-load phase. Additionally, it cleans up the order of different clauses when populating the CREATE TABLE stmt to make it consistent (columns, followed by indexes, followed by column family definition). Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workload/tpcc: remove --deprecated-fk-indexes flag
This commit is effectively a revert of b52aefc. For context, long time ago
(until about 20.2 version) we required that the origin side of the FK
constraint had an index on the foreign key column. That requirement has
been removed, yet we need to keep the support for the schema with those
indexes to allow the workload to run against 20.1 and prior versions. We
don't need that ability anymore, so it should be safe to delete this.
workload/tpcc: add --delay-secondary-indexes flag
We hypothesize that the secondary index build during the load phase of
the IMPORT can significantly slow down the overall performance. TPCC
tables have two secondary indexes, so in order to have more flexibility,
this commit extends the workload with
--delay-secondary-indexesflagwhich makes it so that the tables are initially created only with the
primary index and the secondary indexes are created during the post-load
phase.
Additionally, it cleans up the order of different clauses when
populating the CREATE TABLE stmt to make it consistent (columns,
followed by indexes, followed by column family definition).
Epic: None
Informs: #143076.
Release note: None