Skip to content

release-25.2: changefeedccl: add job tracing support to changefeeds#147103

Open
asg0451 wants to merge 2 commits intocockroachdb:release-25.2from
asg0451:backport25.2-144412-146216
Open

release-25.2: changefeedccl: add job tracing support to changefeeds#147103
asg0451 wants to merge 2 commits intocockroachdb:release-25.2from
asg0451:backport25.2-144412-146216

Conversation

@asg0451
Copy link
Copy Markdown
Contributor

@asg0451 asg0451 commented May 21, 2025

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release justification: improved supportability

asg0451 added 2 commits May 21, 2025 15:33
Adds support for job tracing to changefeeds. This
can be used as an additional debugging tool. The
data stored is summed span counts & times, per
job. The data can be accessed from the db console
like with other jobs.

Epic: none

Release note (ops change): Added job tracing support to changefeeds.
Add more tracing spans to the changefeed job to
help with debugging using job tracing.

Epic: none

Release note: None
@asg0451 asg0451 requested a review from a team as a code owner May 21, 2025 19:34
@asg0451 asg0451 requested review from aerfrei and removed request for a team May 21, 2025 19:34
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 21, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl Bot added the backport Label PR's that are backports to older release branches label May 21, 2025
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 21, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@asg0451 asg0451 removed the request for review from aerfrei May 21, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-cdc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants