Skip to content

Conversation

@kyle-a-wong
Copy link
Contributor

Backport 1/1 commits from #147437 on behalf of @kyle-a-wong.


The activate diagnostics modal runs into an infinite render bug when a statement fingerprint contains an empty string gist.

This commit fixes the infinite render by checking if the gist is an empty string

Fixes: #140639
Epic: None
Release note: None


Release justification:

The activate diagnostics modal runs into an infinite render
bug when a statement fingerprint contains an empty string
gist.

This commit fixes the infinite render by checking if the
gist is an empty string

Fixes: cockroachdb#140639
Epic: None
Release note: None
@kyle-a-wong kyle-a-wong requested a review from a team as a code owner May 28, 2025 21:27
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label May 28, 2025
@kyle-a-wong kyle-a-wong removed the request for review from a team May 28, 2025 21:27
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label May 28, 2025
@kyle-a-wong kyle-a-wong requested a review from dhartunian May 28, 2025 21:27
@blathers-crl blathers-crl bot requested a review from angles-n-daemons May 28, 2025 21:27
@blathers-crl
Copy link

blathers-crl bot commented May 28, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 28, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kyle-a-wong kyle-a-wong merged commit 3f50f4e into cockroachdb:release-25.1 Jun 5, 2025
14 of 15 checks passed
@kyle-a-wong kyle-a-wong deleted the blathers/backport-release-25.1-147437 branch June 5, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-observability v25.1.9

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants